[Bug 614036] Review Request: stdair - C++ Standard Airline IT Library - FE-NEEDSPONSOR

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=614036

--- Comment #6 from Martin Gieseking <martin.gieseking at uos.de> 2010-08-29 14:40:45 EDT ---
(In reply to comment #5)
> Thank you very much for your suggestions !

Hi Son, you're welcome. 


> the libextracppunit is not still removed. It permit
> someone who does not have libextracppunit can nevertheless use stdair. I'll
> remove it when libextracppunit is passed the review.

Unfortunately, that's not possible. Your package can't be approved as long as
it bundles a library. Thus, you should prepare your package as if extracc was
already available. As a consequence, extracc blocks stdair, and you have to
wait until it's approved.

Concerning your current spec file, you should replace %{?el5:FOO} and
%{?rhel:BAR} with FOO and BAR, respectively. And completely drop
%{?el5:BuildRequires: tetex-latex}

The virtual package tex(latex) ensures that the correct packages are referenced
(currently texlive-latex in Fedora, and tetex-latex in EPEL <= 5).
Explicitly adding the BuildRoot tag and cleaning %{buildroot} also doesn't
hurt. So if you plan to maintain this package for EPEL too, just add the
corresponding lines as requested by the EPEL guidelines. Fedora also still
accepts them.

You can drop
  rm -f $RPM_BUILD_ROOT%{_libdir}/lib%{name}.la
  rm -f $RPM_BUILD_ROOT%{_libdir}/libextracppunit.la
The preceding rm statement already removes all .la files.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.