[Bug 588442] Review Request: rubygem-heckle - unit test sadism(tm) at it's core

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=588442

Michael Stahnke <mastahnke at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |mastahnke at gmail.com

--- Comment #1 from Michael Stahnke <mastahnke at gmail.com> 2010-08-29 22:54:00 EDT ---
warning: File listed twice: /usr/share/doc/usr/lib/ruby/gems/1.8-1.4.3
warning: File listed twice:
/usr/share/doc/usr/lib/ruby/gems/1.8-1.4.3/History.txt
warning: File listed twice:
/usr/share/doc/usr/lib/ruby/gems/1.8-1.4.3/Manifest.txt
warning: File listed twice:
/usr/share/doc/usr/lib/ruby/gems/1.8-1.4.3/README.txt

 rpmlint rubygem-heckle-1.4.3-1.fc15.src.rpm 
rubygem-heckle.src: W: patch-not-applied Patch0: heckle-local.patch

rpmlint rubygem-heckle-1.4.3-1.fc15.noarch.rpm 
rubygem-heckle.noarch: E: non-executable-script
/usr/lib/ruby/gems/1.8/gems/heckle-1.4.3/lib/test_unit_heckler.rb 0444L
/usr/bin/env
rubygem-heckle.noarch: E: non-standard-executable-perm
/usr/lib/ruby/gems/1.8/gems/heckle-1.4.3/bin/heckle 0555L
rubygem-heckle.noarch: W: hidden-file-or-dir
/usr/lib/ruby/gems/1.8/gems/heckle-1.4.3/.autotest
rubygem-heckle.noarch: E: non-executable-script
/usr/lib/ruby/gems/1.8/gems/heckle-1.4.3/sample/test/test_heckled.rb 0444L
/usr/bin/env

Again, ruby_sitelib macro isn't used.  Remove that line.

No need for the /usr/share/doc setup again.  Please remove, if you do, the
Rakefile will work for rake test in %check.  You will also need to add a BR on
parse tree for the check.

Rather than patching, you could simply run sed to modify the path for ruby.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.