[Bug 589866] Review Request: darktable - Utility to organize and develop raw images

bugzilla at redhat.com bugzilla at redhat.com
Tue Aug 31 16:07:13 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=589866

--- Comment #30 from Edouard Bourguignon <madko at linuxed.net> 2010-08-31 12:07:12 EDT ---
So here are the latest files, with your suggestions Dmitrij:
Spec: http://www.linuxed.net/~madko/fedora/darktable.spec
SRPM: http://www.linuxed.net/~madko/fedora/darktable-0.6-6.fc13.src.rpm
i386: http://www.linuxed.net/~madko/fedora/darktable-0.6-6.fc13.i686.rpm
x64 : http://www.linuxed.net/~madko/fedora/darktable-0.6-6.fc12.x86_64.rpm

The gconf schemas file still has issues with rpmlint. The macros
(%gconf_schema_*) from
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#GConf create some
"rm" in the scripts. Despite those warnings I hope this is correct.
I have checked some other packages that deal with gconf schema files and they
don't use those macros so is the
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#GConf up to date and
correct?

---
rpmlint:
darktable.x86_64: W: non-conffile-in-etc /etc/gconf/schemas/darktable.schemas
A non-executable file in your package is being installed in /etc, but is not a
configuration file. All non-executable files in /etc should be configuration
files. Mark the file as %config in the spec file.

darktable.x86_64: W: dangerous-command-in-%pre rm
darktable.x86_64: W: dangerous-command-in-%post rm
1 packages and 0 specfiles checked; 0 errors, 3 warnings.
---

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list