[Bug 596593] Review Request: ibus-table-chinese - Chinese tables for IBus-Table

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=596593

Peng Wu <pwu at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pwu at redhat.com

--- Comment #5 from Peng Wu <pwu at redhat.com> 2010-12-01 00:05:34 EST ---
+ Koji build http://koji.fedoraproject.org/koji/taskinfo?taskID=2633878 is
successful.
+ rpmlint is output for SRPM and for RPM.
ibus-table-chinese.src: I: enchant-dictionary-not-found zh_CN
ibus-table-chinese.src: I: enchant-dictionary-not-found zh_TW
ibus-table-chinese.src:339: W: macro-in-comment %doc
ibus-table-chinese.src: W: invalid-url Source0:
http://ibus.googlecode.com/files/ibus-table-chinese-1.3.0.20101126-Source.tar.gz
HTTP Error 404: Not Found
ibus-table-chinese.spec:339: W: macro-in-comment %doc
ibus-table-chinese.spec: W: invalid-url Source0:
http://ibus.googlecode.com/files/ibus-table-chinese-1.3.0.20101126-Source.tar.gz
HTTP Error 404: Not Found
1 packages and 1 specfiles checked; 0 errors, 4 warnings.

+ source files match upstream url (sha1sum)
f92a8dd02cf94df9b81172b1763162d2e3ae6c25
ibus-table-chinese-1.3.0.20101126-Source.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ The description and summary sections in the package spec file should contain
translations for supported Non-English languages, if available.
+ Spec file is legible.
+ dist tag is present.
+ license is open source-compatible.
+ License text is included in package.
+ Macro use appears rather consistent.
+ no duplicates in %files.
+ file permissions are appropriate.

Note: there are two minor issues just mentioned here.
1. ibus-table-chinese-all sub package to pull all ibus tables has no files, so
it is not generated at all.
maybe it can be generated later.
2. there is a warning when doing rpm -V ibus-table-chinese-*
# rpm -V ibus-table-chinese-wu
..5....T.    /usr/share/ibus-table/tables/wu.db
After discussed with Ding-Yi Chen, this need some upstream fixes, so will be
considered later.

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.