[Bug 658796] Review Request: ptpd - implements the Precision Time protocol

bugzilla at redhat.com bugzilla at redhat.com
Wed Dec 1 11:09:18 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=658796

--- Comment #5 from Peter Lemenkov <lemenkov at gmail.com> 2010-12-01 06:09:17 EST ---
Builds fine in koji for F-14

http://koji.fedoraproject.org/koji/taskinfo?taskID=2636504

Notes:

* The 'Packager' field should be removed entirely.
* Reformat %description text to fin into 80-chars lines.
* This package doesn't honour CFLAGS (see build-log)
* No need to explicitly install doc-files. Just mark them as %doc in the %files
section (they will be picked up by rpmbuild automatically from
%{_builddir}/%{buildsubdir}
* This line is generally ok: 

cd %{_builddir}/%{name}-%{version}/src

but I'd rather cut it down to "cd src". You're already in
%{_builddir}/%{buildsubdir} so no need to append it again.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list