[Bug 656363] Review Request: perl-Package-Stash-XS - Faster and more correct implementation of the Package::Stash API

bugzilla at redhat.com bugzilla at redhat.com
Sat Dec 4 05:14:39 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=656363

Iain Arnell <iarnell at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #1 from Iain Arnell <iarnell at gmail.com> 2010-12-04 00:14:38 EST ---
+ source files match upstream.  
    5430594809936af4add03e627c43a42a  Package-Stash-XS-0.17.tar.gz

+ package meets naming and versioning guidelines.
+ specfile is properly named, is cleanly written and uses macros consistently.
+ summary is OK.
+ description is OK.
+ dist tag is present.
+ build root is OK.
+ license field matches the actual license.
    GPL+ or Artistic

+ license is open source-compatible.
+ license text included
+ latest version is being packaged.
+ BuildRequires are proper.
+ compiler flags are appropriate.
+ %clean is present.
+ package builds in mock
    http://koji.fedoraproject.org/koji/taskinfo?taskID=2643009

+ package installs properly.
+ rpmlint has no complaints:
    3 packages and 0 specfiles checked; 0 errors, 0 warnings.

+ final provides and requires are sane:
    perl(Package::Stash::XS) = 0.17
    perl-Package-Stash-XS = 0.17-2.fc15
    perl-Package-Stash-XS(x86-64) = 0.17-2.fc15
=
    libc.so.6()(64bit)  
    libc.so.6(GLIBC_2.2.5)(64bit)  
    perl(:MODULE_COMPAT_5.12.2)  
    perl(strict)  
    perl(warnings)  
    perl(XSLoader)  
    rpmlib(CompressedFileNames) <= 3.0.4-1
    rpmlib(FileDigests) <= 4.6.0-1
    rpmlib(PayloadFilesHavePrefix) <= 4.0-1
    rpmlib(PayloadIsXz) <= 5.2-1
    rpmlib(VersionedDependencies) <= 3.0.3-1
    rpmlib(VersionedDependencies) <= 3.0.3-1
    rtld(GNU_HASH)  
+ %check is present and all tests pass.
    t/00-compile.t ............ ok
    t/01-basic.t .............. ok
    t/02-extension.t .......... ok
    t/03-io.t ................. ok
    t/04-get.t ................ ok
    t/05-isa.t ................ ok
    t/06-addsub.t ............. ok
    t/07-edge-cases.t ......... ok
    t/10-synopsis.t ........... ok
    t/20-leaks.t .............. ok
    t/21-leaks-debug.t ........ ok
    t/release-eol.t ........... ok
    t/release-no-tabs.t ....... ok
    t/release-pod-coverage.t .. ok
    t/release-pod-syntax.t .... ok
    All tests successful.
    Files=15, Tests=297,  1 wallclock secs ( 0.06 usr  0.02 sys +  0.54 cusr 
0.06 csys =  0.68 CPU)
    Result: PASS

+ no shared libraries are added to the regular linker search paths.
+ owns the directories it creates.
+ doesn't own any directories it shouldn't.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no generically named files
+ code, not content.
+ documentation is small, so no -doc subpackage is necessary.
+ %docs are not necessary for the proper functioning of the package.


The patches for EPEL are necessary and applied sanely.

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list