[Bug 659756] Review Request: libnfsidmap - Library that handles mapping between names and ids for NFSv4.

bugzilla at redhat.com bugzilla at redhat.com
Sun Dec 5 12:08:30 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=659756

Ralf Corsepius <rc040203 at freenet.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rc040203 at freenet.de

--- Comment #9 from Ralf Corsepius <rc040203 at freenet.de> 2010-12-05 07:08:29 EST ---
Provided the speed this review was rushed through, I can't deny having uneasy
feeling about this review (Pingpong match?).

Package is not OK:

- ChangeLog date is wrong:
 .. * Fri Dec  3 2006 ...

- Superfluous BR's:
 .. BR: autoconf, automake

- Package supplies *.pc's => Package must own %{_libdir}/pkgconfig
(recent FPG change)

- Hard-coded /etc at several places.
Should be %{_sysconfdir}

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list