[Bug 660095] Review Request: impressive - The stylish way of giving presentations

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=660095

--- Comment #4 from Michael J Gruber <mjg at fedoraproject.org> 2010-12-05 10:41:07 EST ---
> The summary would be better as
>  "A program that displays presentation slides"

I'm happy to change it (just wasn't sure how much to deviate from the old
package).

> 
> **
> 
> The install scenario is a bit odd. I'd probably just install impressive.py as
> %{_bindir}/impressive, but for some reason the past maintainer has implemented
> a wrapper for checking that the hardware has OpenGL acceleration.

That is the recommendation for users of opengl-games-utils.

> 
> The install of the wrapped python script as %{_bindir}/python-impressive seems
> a bit silly. I'd install it as %{python_sitelib}/impressive.py.

Again, this is how other opengl-games-utils users (all of them games it seems)
do it. I can change it, of course, but it would also mean injecting the path
%{python_sitelib} into the wrapper script.

> This is a Python package, so you should add BuildRequires: python-devel to make
> sure everything goes alright.

This package does not build anything and does not use setup.py etc.
(distutils). Maybe it should, but it doesn't...
It's a single standalone python file/program (save the wrapper).

And sorry for the flag, I must have mixed that up. (Or did I do this before?)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.