[Bug 634909] Review Request: v8 - JavaScript Engine

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=634909

--- Comment #15 from Alex Hudson (Fedora Address) <fedora at alexhudson.com> 2010-12-08 10:11:35 EST ---
Immediate problem; the package doesn't build from source. It builds for me with
an additional Build-Requires of gcc-c++ - however, it really should be
mock-clean. I haven't checked a mock build this time around, as I'm just taking
an initial look at the package, but stuff like python-devel is going to be
needed too I think.

rpmlint output:

rpmlint RPMS/x86_64/v8-2.5.9-1.fc14.x86_64.rpm:

v8.x86_64: W: shared-lib-calls-exit /usr/lib64/libv8-2.5.9.so exit at GLIBC_2.2.5
v8.x86_64: W: no-manual-page-for-binary d8
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

I suggest we can ignore these two errors, although even a minimal man page for
d8 would be nice to have.

rpmlint RPMS/x86_64/v8-devel-2.5.9-1.fc14.x86_64.rpm:

v8-devel.x86_64: W: no-documentation
v8-devel.x86_64: E: non-executable-script
/usr/lib/python2.7/site-packages/js2c.py 0644L /usr/bin/env
v8-devel.x86_64: E: non-executable-script
/usr/lib/python2.7/site-packages/jsmin.py 0644L /usr/bin/python2.4
1 packages and 0 specfiles checked; 2 errors, 1 warnings.

I'm not mega worried about the lack of docs (although again, shipping the
samples/* code would be nice I think), but the python stuff needs to be fixed
imho. Arguably the jsmin.py error isn't a problem, although I would much rather
it not have a shebang unless it's actually an executable (esp. since most
Fedora won't have python2.4 around anyway).

Also, I'm not sure js2c.py really is a library - it looks like a utility to me.
I don't think that is the right location for it. 

rpmlint RPMS/x86_64/v8-debuginfo-2.5.9-1.fc14.x86_64.rpm:

v8-debuginfo.x86_64: E: script-without-shebang
/usr/src/debug/v8-2.5.9/src/compiler.cc
v8-debuginfo.x86_64: E: script-without-shebang
/usr/src/debug/v8-2.5.9/src/scanner.cc
v8-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/v8-2.5.9/include/v8-debug.h
1 packages and 0 specfiles checked; 2 errors, 1 warnings.

Various permissions errors here which should be fixed. The install -pm approach
used in part of the specfile I think would be better - you could then lose the
chmods and it would look a bit tidier.

Other nits:

- if you're going to use %{} macros, %{buildroot} looks nicer than
$RPM_BUILD_ROOT rather than mixing the two styles

- the .spec has some tabs and spaces mixed

- Packaging guildelines state use of "ExcludeArch" with appropriate BZ
references per-arch instead of "ExclusiveArch".

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.