[Bug 660625] Review Request: techne - A general purpose, programmable physical simulator and renderer

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=660625

--- Comment #3 from Tadej Janež <tadej.janez at tadej.hicsalta.si> 2010-12-09 10:01:35 EST ---
Hans, thanks for the review!

(In reply to comment #2)
> MUST FIX / needs work:
> - sources match upstream
> I cannot verify this, please ask upstream to put a pre-release / alpha
> / beta tarbal somewhere.

I'm in contact with the upstream author and he'll put a tarball out shortly.

> - owns all directories that it creates
> Currently the package does not own the following dirs:
> %{_libdir}/%{name}
> %{_datadir}/%{name}
> %{_datadir}/%{name}/common
> This can be fixed by replacing (in %files) this:
> %{_libdir}/%{name}/*.so
> %{_libdir}/%{name}/*.bin
> %{_datadir}/%{name}/common/*
> With:
> %{_libdir}/%{name}
> %{_datadir}/%{name}

Thanks for pointing this out, fixed.

> - release field not properly used.
> Since this is a pre release version being used the release field
> should be something like:
> Release: 0.1%{?dist}
> or:
> Release: 0.1.beta1%{?dist}

Fixed.

The updated SPEC and SRPM files are available at:
http://tadej.fedorapeople.org/techne.spec
http://tadej.fedorapeople.org/techne-0.2-0.2.fc13.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.