[Bug 661436] Review Request: rubygem-heroku - deploy apps to Heroku

bugzilla at redhat.com bugzilla at redhat.com
Fri Dec 10 17:48:52 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=661436

Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtasaka at ioa.s.u-tokyo.ac.jp

--- Comment #4 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> 2010-12-10 12:48:52 EST ---
Some notes:

* Unused macros
  - The defined macro %ruby_sitelib is used nowhere.
  - Please use the defined %geminstdir macro also in %files

* License
  - The license is MIT

* source URL
  - Please specify the full URL for Source0
    https://fedoraproject.org/wiki/Packaging/SourceURL

* BuildRoot
  - On Fedora BuildRoot line is no longer needed:
    https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag

* documents / -doc subpackage
  - Please consider to split document files (which are not
    needed on runtime) to -doc subpackage.
    The following files/directories can be moved to -doc subpackage
------------------------------------------------------
%{gemdir}/doc/%{gemname}-%{version}/
%{geminstdir}/spec/
------------------------------------------------------
  - Please mark %geminstdir/README.md as %doc correctly.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list