[Bug 634909] Review Request: v8 - JavaScript Engine

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=634909

--- Comment #18 from Alex Hudson (Fedora Address) <fedora at alexhudson.com> 2010-12-10 13:49:55 EST ---
Nice job Lubomir.

There's still a permissions problem in debuginfo:

$ rpmlint RPMS/x86_64/v8-debuginfo-2.5.9-2.fc14.x86_64.rpm 
v8-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/v8-2.5.9/include/v8-debug.h
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

Otherwise, the packages look very clean; I've done the full check against the
Guidelines and I can't see anything new that we haven't already got on the bug.

One minor comment/question:  is there a reason you're pulling from trunk?

  # U=http://v8.googlecode.com/svn/trunk/
  # R=$(svn log $U |awk '/^r[0-9]* / {r=$1} /2\.5\.9/ {print r; exit}')
  # svn export -$R $U v8-2.5.9
  # tar czf v8-2.5.9.tar.gz v8-2.5.9

I would normally expect a tagged pull, e.g. 

  # svn export http://v8.googlecode.com/svn/tags/2.5.9/ v8-2.5.9
  # tar czf v8-2.5.9.tar.gz v8-2.5.9

As well as losing $U and $R, I would think it would be more reliable for
finding the right source than trawling the svn log. If the tag is different to
what ends up on trunk (?!) that would be worth an extra comment I think. 

There is another problem remaining:

> - Packaging guildelines state use of "ExcludeArch" with appropriate BZ
> references per-arch instead of "ExclusiveArch".

Having thought about it, I'm inclined to agree with you. My understanding of
the guideline is that we should only list known-not-to-work arches so that if
some new arch comes along, we give it the benefit of the doubt until it's shown
also not to work.

However, in the case of v8 (which is really a JIT/compiler), that's not a
sensible approach: it's not going to magically support new arches without
significant upstream work.

But we're left with the problem that this guideline is a MUST:, and that this
problem is therefore considered to be a blocker. I will raise this on
fedora-devel-list as I think this is a problem for me as the reviewer, rather
than you as packager. However, if you wanted to change this to ExcludeArch in
the meantime for the purposes of passing the review, that would be ok too.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.