[Bug 661902] Review Request: moksha - A platform for creating real-time web applications

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=661902

--- Comment #4 from Casey Dahlin <cdahlin at redhat.com> 2010-12-10 17:39:56 EST ---
Actually remembered to run the lint tool on the output this time.

moksha.noarch: W: spelling-error %description -l en_US jQuery -> j Query,
query, equerry

Ignore

moksha.noarch: E: script-without-shebang
/usr/lib/python2.7/site-packages/moksha/widgets/blueprint/static/src/print.css
moksha.noarch: E: script-without-shebang
/usr/lib/python2.7/site-packages/moksha/widgets/blueprint/static/src/grid.css
moksha.noarch: E: wrong-script-end-of-line-encoding
/usr/lib/python2.7/site-packages/moksha/widgets/blueprint/static/src/grid.css
moksha.noarch: E: script-without-shebang
/usr/lib/python2.7/site-packages/moksha/widgets/blueprint/static/plugins/sprites/sprite.css

These are being installed with +x. Fix please.

moksha.noarch: E: non-executable-script
/usr/lib/python2.7/site-packages/moksha/commands/cli.py 0644L /usr/bin/env

I think ignore... looks like it found a shebang in it? Should that be there?

moksha.noarch: W: hidden-file-or-dir
/usr/lib/python2.7/site-packages/moksha/api/widgets/buttons/static/images/orange/.DS_Store

NO! This needs fixing

moksha.noarch: E: non-standard-dir-perm /var/lib/moksha 0700L

Is this necessary? If so carry on.

moksha.noarch: E: script-without-shebang
/usr/lib/python2.7/site-packages/moksha/widgets/blueprint/static/src/reset.css

Another css file with +x.

moksha.noarch: W: hidden-file-or-dir
/usr/lib/python2.7/site-packages/moksha/api/widgets/buttons/static/images/default/.DS_Store

Again. No friggin way.

moksha.noarch: W: no-manual-page-for-binary moksha-hub
moksha.noarch: W: no-manual-page-for-binary moksha

Knew about these.

moksha.noarch: E: init-script-without-chkconfig-postin /etc/init.d/moksha-hub
moksha.noarch: E: init-script-without-chkconfig-preun /etc/init.d/moksha-hub

Probably a good idea to fix.

moksha.noarch: E: no-chkconfig-line /etc/init.d/moksha-hub

Do fix this one.

moksha.noarch: W: incoherent-init-script-name moksha-hub ('moksha', 'mokshad')

Ignore (God there's some stupid checks in lint these days).

moksha.src: W: spelling-error %description -l en_US jQuery -> j Query, query,
equerry

Ignore

moksha-docs.noarch: W: hidden-file-or-dir
/usr/share/doc/moksha-docs-0.5.0/html/.buildinfo

What is this?

moksha-server.noarch: W: spelling-error Summary(en_US) wsgi -> swig, wigs
moksha-server.noarch: W: summary-not-capitalized C mod_wsgi Moksha server
moksha-server.noarch: W: spelling-error %description -l en_US wsgi -> swig,
wigs
moksha-server.noarch: W: no-documentation

Ugh. Ignore all of these.

moksha-server.noarch: E: executable-marked-as-config-file
/etc/httpd/conf.d/moksha.conf
moksha-server.noarch: E: script-without-shebang /etc/httpd/conf.d/moksha.conf
moksha-server.noarch: E: script-without-shebang
/usr/share/moksha/production/rabbitmq/rabbitmq-codegen-amqp-codegen.patch
moksha-server.noarch: E: script-without-shebang
/usr/share/moksha/production/sample-production.ini

More extraneous +x bits.

moksha-server.noarch: E: non-standard-dir-perm /var/cache/moksha 0700L

Again please inform me if this is necessary.

moksha-server.noarch: E: script-without-shebang
/usr/share/moksha/production/apache/moksha.conf
moksha-server.noarch: E: script-without-shebang
/usr/share/moksha/production/nginx/moksha.conf
moksha-server.noarch: E: script-without-shebang
/usr/share/moksha/production/apache/moksha.wsgi
moksha-server.noarch: E: script-without-shebang
/usr/share/moksha/production/orbited.cfg

And more useless +x bits.


On another note:
yum list | sed 's/\..*//' | grep -e '-docs\?$' | awk -F- '{ print $NF }' | sort
| uniq -c

Yields:
    443 doc
    102 docs

So renaming the -docs package to -doc would make me personally happy. OCD is
delicious.

Looks like the rest of the old stuff is fixed though.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.