[Bug 661660] Review Request: metamorphose2 - A cross platform file and folder mass renamer

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=661660

--- Comment #3 from Pierre-YvesChibon <pingou at pingoured.fr> 2010-12-12 09:06:12 EST ---
(In reply to comment #2)
> Some comments:
> 
> * The version should be 0.7.1, instead of 2.0.7.1. The RPMs and
>   DEBs files provided by upstream have this version by the way.

Although I agree to do the change, it means that the software will have to be
renamed for metamorphose 3.

I would rather change the name to metamorphose and keep the 2 in the version
number.

> * You should set as BR python2 and not python (in case of a switch to python3
> as
>   default Python interpreter).

I'll do this.

> * The .desktop file is not Freedesktop-compliant: see the validation error
>   returned by desktop-file-install: 
>     metamorphose2.desktop: error: (will be fatal in the future): value
>     "Filesystem" in key "Categories" in group "Desktop Entry" requires another
>     category to be present among the following categories: System

sed -i -e "s|Categories=Utility;Filesystem;|Categories=Utility;System;|"
metamorphose2.desktop
added in %prep.

I will upload the new version once I hear your opinion about the name/version
problem.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.