[Bug 252108] Review Request: python-html5lib - A python based HTML5 parser/tokenizer

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=252108

Oded Arbel <oded at geek.co.il> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #464828|0                           |1
        is obsolete|                            |

--- Comment #24 from Oded Arbel <oded at geek.co.il> 2010-12-12 12:15:09 EST ---
Created attachment 468243
  --> https://bugzilla.redhat.com/attachment.cgi?id=468243
Updated spec file according to comments

Thanks for the comments :-)

(In reply to comment #23)
> Replace %define modulename htmllib with %global modulename htmllib:

Done.

> The %define python_sitelib isn't needed anymore (since F-13):

Done.

> The same goes for the BuildRoot tag and the %clean section:

Done. I should really sit down and read the packaging guidelines from top to
bottom.

> What's with all the #---------------?
> Please drop them.

Its from a template I use for creating new spec files - in my company we expect
developers to maintain their own spec files and I find it helps newbies. I've
removed them.

> We're on F-14 now, so that conditional isn't needed.

Done.

> The %files section is a bit too general for my taste.
> Adding files explicitly helps you by breaking the build when newer versions of
> htmllib decide to drop/add files.

I've changed the %files section to specifically list all the python packages
that are expected to exist (as I've seen some other python RPMs do). It's not a
lot more specific then your example, I hope that's OK.

> In the %pre section:
> isn't needed, that's handled by the %setup macro.

Removed.

> And what about the tests? You should run them in a %check section, if possible.

I've added %check with the tests, but on my system almost all of them fail. I'm
not an html5lib developer so I'm not sure who's at fault here, so I commented
it out in the mean time. I'll check whats up with that when I have the time.

SRPM and precompiled binary for Fedora 14 are again available at
http://rpms.geek.co.il/fc14/SRPMS/python-html5lib-0.11-2.fc14.src.rpm and
http://rpms.geek.co.il/fc14/x86_64/python-html5lib-0.11-2.fc14.noarch.rpm.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.