[Bug 523540] Review Request: opentracker - BitTorrent Tracker

bugzilla at redhat.com bugzilla at redhat.com
Sun Dec 12 22:08:41 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=523540

--- Comment #71 from Stefan Neufeind <redhat at stefan-neufeind.de> 2010-12-12 17:08:39 EST ---
Small enhancement-suggestion for the init-scripts: opentracker supports sending
it a SIGHUP as well to re-read the configuration (for example if you use it in
whitelist/blacklist-mode to re-read the lists without disruption).

Part can simply be taken from another Fedora-init-script (for example snmpd):
reload(){
        echo -n $"Reloading $prog: "
        killproc -p $pidfile $binary -HUP
        RETVAL=$?
        echo
        return $RETVAL
}

And maybe stop should also be using the pidfile instead of just using the
program-name (also for example from snmpd):

stop() {
        echo -n $"Stopping $prog: "
        if [ $UID -ne 0 ]; then
                RETVAL=1
                failure
        else
                killproc -p $pidfile $binary
                RETVAL=$?
                [ $RETVAL -eq 0 ] && rm -f $lockfile
        fi;
        echo
        return $RETVAL
}

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list