[Bug 661961] Review Request: kyotocabinet - A lightweight database library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=661961

Steve Milner <smilner at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #4 from Steve Milner <smilner at redhat.com> 2010-12-13 10:38:58 EST ---
+ = good
- = bad
o = informational

$ rpmlint
/usr/local/steve/rpmbuild/RPMS/i686/kyotocabinet-1.2.27-2.fc13.i686.rpm
/usr/local/steve/rpmbuild/RPMS/i686/kyotocabinet-devel-1.2.27-2.fc13.i686.rpm
/usr/local/steve/rpmbuild/RPMS/i686/kyotocabinet-api-doc-1.2.27-2.fc13.i686.rpm
/usr/local/steve/rpmbuild/RPMS/i686/kyotocabinet-debuginfo-1.2.27-2.fc13.i686.rpm
4 packages and 0 specfiles checked; 0 errors, 0 warnings.

+ the  file, containing the text of the license(s) for the package must be
included in %doc (%doc workaround is being used)
+ rpmlint clean
+ ldconfig is being used in post and postun
+ owns all directories that it creates.
+ file list looks sane
+ Permissions on files are be set properly.
+ Package consistently use macros.
+ The package contains code
+ Large documentation files are in a -doc subpackage.
+ doc package is not required for execution
+ Header files are in a -devel package
+ No static libraries
+ package contains library files with a suffix and library files that end in
.so (without suffix) are in a -devel package.
+ devel package requires main package
+ no .la files
+ Not a desktop application so no need for .desktop file(s)
+ Package does not own files owned by other packages
+ Filenames are valid UTF-8
+ The package meets the Packaging Guidelines
o You may want to change Source0 to
http://fallabs.com/%{name}/pkg/%{name}-%{version}.tar.gz ... though it is not
required.
o You may want to look and see if your directory ownership listing should use
%dir or not

Setting fedora-review to +

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.