[Bug 609295] Review Request: python-cement - CLI Application Framework for Python

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=609295

--- Comment #4 from Jason Tibbitts <tibbs at math.uh.edu> 2010-12-14 11:58:16 EST ---
A few comments:

Do I recall correctly that you are the upstream developer of this software?  It
would probably have benefited you to let us know about that.

Are you sure you still need to pass --single-version-externally-managed to
setuptools?  http://fedoraproject.org/wiki/Packaging:Python_Eggs indicates that
this should no longer be required, and that document is a few years old now.

Nothing seems to own %{python_sitelib}/%{real_name}.  You include a few
subdirectories but not the directory itself.  And, what does %{real_name}
actually buy you, anyway?  Isn't it shorter to simply type "cement"?

It looks like you have a bunch of nasty macroification at the top which is
unnecessary for Fedora (or even EL6).  You could dispense with %pyver just by
using globs in your file lists, and I'm not sure what the %python macro is used
for at all.  Some of the spec is so buried in pointless macros that it becomes
quite difficult to understand.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.