[Bug 663181] Review Request: ompc - MATLAB to Python syntax adapting compiler

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=663181

--- Comment #1 from Jussi Lehtola <jussi.lehtola at iki.fi> 2010-12-15 03:14:13 EST ---
rpmlint output:
ompc.src: E: invalid-version 1.0beta
ompc.src: W: summary-ended-with-dot C MATLAB to Python syntax adapting
compiler.
ompc.src: W: strange-permission ompc_gen_tarball.sh 0775L
ompc.src: W: patch-not-applied Patch1:
ompc-1.0beta-fix_compilation_for_ompc_supported.patch
ompc.src: W: patch-not-applied Patch2:
ompc-1.0beta-remove_ompc_pth_from_setup.patch
ompc.src: W: invalid-url Source0: ompc-1.0beta.tar.bz2
ompc.x86_64: E: invalid-version 1.0beta
ompc.x86_64: W: summary-ended-with-dot C MATLAB to Python syntax adapting
compiler.
ompc.x86_64: E: no-binary
ompc.x86_64: W: no-documentation
ompc.x86_64: W: devel-file-in-non-devel-package
/usr/lib/python2.7/site-packages/ompceg/test.c
ompc.x86_64: W: devel-file-in-non-devel-package
/usr/lib/python2.7/site-packages/ompceg/test.h
ompc-debuginfo.x86_64: E: invalid-version 1.0beta
ompc-debuginfo.x86_64: E: empty-debuginfo-package
3 packages and 0 specfiles checked; 5 errors, 9 warnings.

Please drop the unnecessary commented lines that remain from the python spec
file template.

Tag the package as BuildArch: noarch, as it is architecture independent.

Drop the patches if you don't need them.

Get rid of the test files.

You will need to stick to
 http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Package_Versioning
Having the git snapshot identifier in the release is IMHO quite pointless. I'd
use the date, which is a lot more understandable.

Abusive use of wildcards can lead to trouble. Avoid their use, unless
absolutely necessary. For instance this package has a clearly broken install.
The contents of %{python_sitelib} should be

%{python_sitelib}/ompc/
%{python_sitelib}/OMPC-*.egg-info

Currently there's a big bunch of additional stuff that in no case belongs
there, such as

/usr/lib/python2.7/site-packages/test.py
/usr/lib/python2.7/site-packages/test.pyc
/usr/lib/python2.7/site-packages/test.pyo
/usr/lib/python2.7/site-packages/LICENSE
/usr/lib/python2.7/site-packages/OMPC-1.0_beta-py2.7.egg-info
/usr/lib/python2.7/site-packages/README
/usr/lib/python2.7/site-packages/licenses
/usr/lib/python2.7/site-packages/licenses/ply
/usr/lib/python2.7/site-packages/licenses/ply/ANNOUNCE
/usr/lib/python2.7/site-packages/licenses/ply/CHANGES
/usr/lib/python2.7/site-packages/licenses/ply/COPYING
/usr/lib/python2.7/site-packages/licenses/ply/README
/usr/lib/python2.7/site-packages/licenses/ply/TODO
/usr/lib/python2.7/site-packages/ompc.cfg
/usr/lib/python2.7/site-packages/ompceg
/usr/lib/python2.7/site-packages/ompceg/ompceg.py
/usr/lib/python2.7/site-packages/ompceg/ompceg.pyc
/usr/lib/python2.7/site-packages/ompceg/ompceg.pyo
/usr/lib/python2.7/site-packages/ompceg/test.c
/usr/lib/python2.7/site-packages/ompceg/test.h
/usr/lib/python2.7/site-packages/ompclib
/usr/lib/python2.7/site-packages/ompclib/__init__.py
/usr/lib/python2.7/site-packages/ompclib/__init__.pyc
/usr/lib/python2.7/site-packages/ompclib/__init__.pyo
/usr/lib/python2.7/site-packages/ompclib/byteplay.py
/usr/lib/python2.7/site-packages/ompclib/byteplay.pyc
/usr/lib/python2.7/site-packages/ompclib/byteplay.pyo
/usr/lib/python2.7/site-packages/ompclib/m_compile.py
/usr/lib/python2.7/site-packages/ompclib/m_compile.pyc
/usr/lib/python2.7/site-packages/ompclib/m_compile.pyo
/usr/lib/python2.7/site-packages/ompclib/matpy.py
/usr/lib/python2.7/site-packages/ompclib/matpy.pyc
/usr/lib/python2.7/site-packages/ompclib/matpy.pyo
/usr/lib/python2.7/site-packages/ompclib/matpy_gnuplot.py
/usr/lib/python2.7/site-packages/ompclib/matpy_gnuplot.pyc
/usr/lib/python2.7/site-packages/ompclib/matpy_gnuplot.pyo
/usr/lib/python2.7/site-packages/ompclib/matpy_platform.py
/usr/lib/python2.7/site-packages/ompclib/matpy_platform.pyc
/usr/lib/python2.7/site-packages/ompclib/matpy_platform.pyo
/usr/lib/python2.7/site-packages/ompclib/ompc_narginout.py
/usr/lib/python2.7/site-packages/ompclib/ompc_narginout.pyc
/usr/lib/python2.7/site-packages/ompclib/ompc_narginout.pyo
/usr/lib/python2.7/site-packages/ompclib/ompc_supported.py
/usr/lib/python2.7/site-packages/ompclib/ompc_supported.pyc
/usr/lib/python2.7/site-packages/ompclib/ompc_supported.pyo
/usr/lib/python2.7/site-packages/ompclib/ompclib_numpy.py
/usr/lib/python2.7/site-packages/ompclib/ompclib_numpy.pyc
/usr/lib/python2.7/site-packages/ompclib/ompclib_numpy.pyo
/usr/lib/python2.7/site-packages/ompclib/ompclib_numpy_base.py
/usr/lib/python2.7/site-packages/ompclib/ompclib_numpy_base.pyc
/usr/lib/python2.7/site-packages/ompclib/ompclib_numpy_base.pyo
/usr/lib/python2.7/site-packages/ompclib/ompclib_platform.py
/usr/lib/python2.7/site-packages/ompclib/ompclib_platform.pyc
/usr/lib/python2.7/site-packages/ompclib/ompclib_platform.pyo

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.