[Bug 663102] Review Request: pyscard - python module adding smart cards support.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=663102

Steve Traylen <steve.traylen at cern.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |steve.traylen at cern.ch

--- Comment #2 from Steve Traylen <steve.traylen at cern.ch> 2010-12-15 13:39:47 EST ---
Hi Andrew,

This is looking pretty good and thorough for a first package.

Immediate things I notice, you are not compiling with correct compiler options,
look at the example CFLAGS settings on the Python guidelines page and 

http://fedoraproject.org/wiki/PackagingGuidelines#Compiler_flags

for a more general explanation.

Concerning smartcard vs smart-card  just because upstream is using
the spelling of smartcard does not mean your .spec file has to... Though
in this case smartcard seems to be in pretty common usage to me.

More generally for obtaining sponsorship can continue to follow

http://fedoraproject.org/wiki/PackageMaintainers/HowToGetSponsored

and submit another package or two and provide some informal reviews
of other reviews:

http://fedoraproject.org/PackageReviewStatus/

report back here with links to some informal package review bugs you
have done.

When you review head this with "this is an informal review while I try
to obtain package sponsorship" or something.

Steve

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.