[Bug 611054] Review Request: python-carrot - AMQP Messaging Framework for Python

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=611054

Andrew Elwell <andrew.elwell at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrew.elwell at gmail.com

--- Comment #3 from Andrew Elwell <andrew.elwell at gmail.com> 2010-12-16 05:46:12 EST ---
Hi, As I'm hoping to become a packager I've done an informal review of this
package. 

Full comments on the ReviewGuidelines are attached, but a couple of things I'd
like to highlight are:

* no CFLAGS in the %build section -- see 
http://fedoraproject.org/wiki/PackagingGuidelines#Compiler_flags
CFLAGS="$RPM_OPT_FLAGS" %{__python} setup.py build

* your dependency on 'Requires:       python-json' means I couldn't install it
on a stock F14 laptop -- which json implementation do you need?

* rpmlint threw warnings about no buildroot. 
BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
is the default that comes with rpmdev-newspec

* finally upstream says on https://github.com/ask/carrot/#readme
that "Carrot is discontinued in favor of the new Kombu framework.

Kombu is ready, start to use it now!
Kombu comes with a Carrot compatible API, so it's easy to port your software.
Carrot will not be actively maintained, only critical bugs will be fixed."

-- you may want to mention this in the description...

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.