[Bug 609295] Review Request: python-cement - CLI Application Framework for Python

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=609295

Jason Tibbitts <tibbs at math.uh.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |tibbs at math.uh.edu
               Flag|                            |fedora-review?

--- Comment #9 from Jason Tibbitts <tibbs at math.uh.edu> 2010-12-16 15:32:37 EST ---
Everything does look much cleaner, thanks.  (Although you don't have to make
changes just because I suggest that they might look cleaner; it's a dialogue
and I'm not making any demands.)

I still think that pyver is unnecessary and can be replaced by globs, but it
isn't a really big deal.

Can you explain what pkguytil.py is for?  I'm trying to understand why it needs
to be there (since all non-EOL Fedora releases have python >= 2.6, as does
EL6), whether it gets used and whether it could be removed.  The question is
whether it runs afoul of our bundled library policy.

Note that the License: tag stuff should be from the perspective of the built
rpms, so when listing the license bits you should give the location of the file
as it's installed, instead of where it appears in the source tree.


* source files match upstream.  sha256sum:
  4053518c5fe884f9b7d8b363ee06f3273b2274aff7be66cedcc9e25a26aa83ba
   cement-0.8.14.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* rpmlint has acceptable complaints.
* final provides and requires are sane:
  python-cement-0.8.14-3.fc15.noarch.rpm
   python-cement = 0.8.14-3.fc15
  =
   python  
   python(abi) = 2.7
   python-configobj  
   python-genshi  
   python-jsonpickle  

  python-cement-devtools-0.8.14-3.fc15.noarch.rpm
   python-cement-devtools = 0.8.14-3.fc15
  =
   python(abi) = 2.7
   python-cement = 0.8.14-3.fc15
   python-paste-script  
   python-tempita  

  python-cement-doc-0.8.14-3.fc15.noarch.rpm
   python-cement-doc = 0.8.14-3.fc15
  =
   (none)

* %check is present and all tests pass:
   Ran 72 tests in 0.122s
   OK

? pkgutil.py might be bundled.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no generically named files

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.