[Bug 661436] Review Request: rubygem-heroku - deploy apps to Heroku

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=661436

--- Comment #35 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> 2010-12-25 11:44:42 EST ---
Well,

(In reply to comment #32)
> heroku.gem have Runtime Dependencies = launchy ~> 0.3.2
> 
> Now my template generate
> Requires: rubygem(launchy) >= 0.3.2
> 
>  Is need to generate 2 Requires?
> Sample:
> Requires: rubygem(launchy) >= 0.3.2
> Requires: rubygem(launchy) < 0.4

- Usually we write "Requires: rubygem(launchy) >= 0.3.2" part
  only, however technically writing also 
  "Requires: rubygem(launchy) < 0.4" is not wrong (according to
  rubygem's dependency format).

  I asked on fedora-packaging mailing list how people think about
  writing both Requires (especially for writing "lower" Requires):
  http://lists.fedoraproject.org/pipermail/packaging/2010-November/007501.html

  ... and got no answer, so for now I think that you can write
  "Requires: rubygem(launchy) < 0.4" also _if you want_. 


(In reply to comment #33)
> heroku.gem have spec/ folder.
> 
> Is need to realize %check section?
> Like that
> #%check
> #pushd %{buildroot}/%{geminstdir}
> #%_bindir/spec spec
> #popd

- Yes, it is preferable, however for this gem $ spec spec/
  needs webmock gem, which is not in Fedora and currently review
  request for rubygem-webmock does not exist either (once
  existed but it was closed unfinished: bug 588477)

  If you use rubygem-webmock you can package the srpm for Fedora.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.