[Bug 665995] Review Request: fmit - Free Music Instrument Tuner

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=665995

--- Comment #8 from Damian Wrobel <dwrobel at ertelnet.rybnik.pl> 2010-12-29 15:15:03 EST ---
(In reply to comment #7)

Volker, I have already a patch prepared for that[1] as I've even considered to
inform the upstream but the problem is that I'm not sure whether the author
should change anything. IMHO the makefiles are written properly and it looks
that the cmake add_library[2] works in that way that someone can change the
behaviour defining the BUILD_SHARED_LIBS variable (using default values
everything works properly). The only doubt I have is why the
/etc/rpm/macros.cmake overwrites it unconditionally? Thus to avoid patching
something which is correct I prefer to just revert the BUILD_SHARED_LIBS to its
default value.

[1].
http://dwrobel.fedorapeople.org/projects/patches/fmit/fmit-add-library-static.patch
[2]. http://www.cmake.org/cmake/help/cmake-2-8-docs.html#command:add_library

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.