[Bug 665995] Review Request: fmit - Free Music Instrument Tuner

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=665995

--- Comment #10 from Kevin Kofler <kevin at tigcc.ticalc.org> 2010-12-29 17:54:08 EST ---
In short:
* if you DON'T want to install your library for other programs to use:
  - use add_library(STATIC …) to make it always static
  - ask whether that stuff should be built as a library in the first place,
    it could be all put into the same executable target
* if you want to install your library for other programs to use:
  - use add_library without an explicit STATIC or SHARED qualifier
  - use set_target_properties to set a SOVERSION and a full VERSION;
    in particular, bump SOVERSION whenever you break binary compatibility
  - consider using:
    SET(BUILD_SHARED_LIBS ON CACHE BOOL
        "Build shared libraries (.dll/.so) instead of static ones (.lib/.a)")
    to change the default (but either way, this can be set by the user,
    "set" just fixes the default)
* DO NOT ASSUME that the default is STATIC (and in particular, also DO NOT
  force SHARED in add_library unless the library really CANNOT be static;
  use set(BUILD_SHARED_LIBS ON) instead if that's what you want; that way,
  it can be overridden by the user).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.