[Bug 540996] Review Request: rubygem-ffi - Foreign Function Interface package for Ruby

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=540996

--- Comment #4 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> 2010-02-01 11:37:09 EST ---
Some notes:

* %define -> %global
  - We now prefer to use %global %instead of %define
   
https://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over_.25define


* Requires
  - Please use "Requires: rubygem(rake-compiler)" style, ref:
    https://fedoraproject.org/wiki/Packaging/Perl#Perl_Requires_and_Provides

* strip / debuginfo rpm
  - Don't use ELF binary by yourself and create debuginfo rpm correctly.
    ! Note
      To create debuginfo rpm correctly, you have to compile C source
      under %_builddir
      ( i.e. when rubygem contains C extention library, you cannot install
        gem file into %buildroot directly. You have to once install gem file
        under directory created by %setup and then copy the whole tree
        to %buildroot for correct debuginfo rpm creation:
       
https://fedoraproject.org/wiki/Packaging/Ruby#Ruby_Gem_with_extension_libraries_written_in_C
)

    ! Note 2
      Also, build log shows that compilation of C source to create
      libffi_c.so is executed both under %_builddir and %buildroot, this
      is just redundant.

* macro usage
  - %ruby_sitelib macro seems to be used nowhere and unneeded.

  - Please use the defined %geminstdir also in %files

  - You should not use %buildroot vs $RPM_BUILD_ROOT, %optflags vs
$RPM_OPT_FLAGS
    with mixed style and should choose one style.
   
https://fedoraproject.org/wiki/Packaging/Guidelines#Using_.25.7Bbuildroot.7D_and_.25.7Boptflags.7D_vs_.24RPM_BUILD_ROOT_and_.24RPM_OPT_FLAGS

* Documents location
--------------------------------------------------------------
%doc README.rdoc LICENSE History.txt
--------------------------------------------------------------
  - These files should be installed under %geminstdir (in fact
    2 of them are already installed).
    Also document files under %geminstdir should be marked
    as %doc properly.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.