[Bug 225302] Merge Review: automake

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=225302

Paul Howarth <paul at city-fan.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |paul at city-fan.org
               Flag|                            |fedora-review?

--- Comment #10 from Paul Howarth <paul at city-fan.org> 2010-02-02 10:14:20 EST ---
Review:

- rpmlint output:

automake.noarch: W: devel-file-in-non-devel-package
/usr/share/automake-1.11/ansi2knr.c
automake.src: W: strange-permission filter-requires-automake.sh 0775
automake.src: W: strange-permission filter-provides-automake.sh 0775

rpmlint is wrong about automake being a non-devel package so the first one
can be ignored.

the filtering could be done more cleanly as mentioned in comment 7, which
would resolve the automake.src warnings but that's not a blocker.

- package and spec file naming OK
- package meets guidelines
- license OK, matches sources
- spec file written in English and is legible
- sources match upstream
- package builds OK in mock for Rawhide (x86_64)
- buildreqs OK
- no translations, shared or static libraries to worry about
- no bundled libraries
- package not relocatable
- directory ownership OK
- file permissions OK
- %defattr and %clean present and correct
- macro usage is consistent
- only code and permissable content included
- docs not excessively large and don't affect runtime
- not a GUI app, no .desktop file needed
- no libtool libraries present
- buildroot properly cleaned at start of %install
- filenames all US-ASCII

Comments:

The comment in %description about also needing to install autoconf is
redundant since there is a package dependency on autoconf.

Whilst macro usage is consistent, variable usage isn't, i.e. we have:
$RPM_BUILD_ROOT
${RPM_BUILD_ROOT}
$RPM_BUILD_ROOT/
Please stick to one of the first two forms; either would be OK.

Hangovers from previous comments:

- have the manpages been submitted upstream? (Comment 8)
- URL needs updating; existing URL is a redirect to
http://sourceware.org/automake/
  (Comment 8)
- requires/provides filters could be cleaner (Comment 7)

None of the identified issues are blockers so I'm inclined to approve this
package unless anyone else has anything they'd like to bring up?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.