[Bug 504476] Review Request: rubygem-newgem - Bundle Ruby libraries into a RubyGem

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=504476

Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|jan.klepek at hp.com           |mtasaka at ioa.s.u-tokyo.ac.jp
               Flag|fedora-review?,             |fedora-review+
                   |needinfo?(lkundrak at v3.sk)   |

--- Comment #18 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> 2010-02-02 13:18:50 EST ---
@Jan:

Thank you for replying. Since currently this review request
blocks some other requests, I will take over this review.

(In reply to comment #15)
> >   - Would you check if the following dependencies are optional or
> >     rather mandatory?
> > -------------------------------------------------------------
> > ./lib/newgem/rubyforge-ext.rb:  require 'rubyforge'
> > -------------------------------------------------------------    
> 
> Looks pretty mandatory to me and is currently pulled in by the hoe dependency.
> Having trouble recalling the best practice for this and can't spot it in the
> guidelines - should I be explicitly listing rubyforge as a dependency?    

- Thank you for the catch. For this I will leave to how you
  think.

-----------------------------------------------------------------
    This package (rubygem-newgem) is APPROVED by mtasaka
-----------------------------------------------------------------

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.