[Bug 561128] New: Package review: aide

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Package review: aide

https://bugzilla.redhat.com/show_bug.cgi?id=561128

           Summary: Package review: aide
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: ASSIGNED
          Severity: medium
          Priority: low
         Component: Package Review
        AssignedTo: mitr at redhat.com
        ReportedBy: mitr at redhat.com
         QAContact: extras-qa at fedoraproject.org
                CC: notting at redhat.com, sgrubb at redhat.com,
                    fedora-package-review at redhat.com
   Estimated Hours: 0.0
    Classification: Fedora
    Target Release: ---


Miloslav Trmač <mitr at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review?

(There probably used to be a review in Extras.)

* Licensing problems:
  * src/fopen.c contains:
    > 2. Redistributions in binary form must reproduce the above copyright
    >    notice, this list of conditions and the following disclaimer in the
    >    documentation and/or other materials provided with the distribution.
    - the BSD advertising clause, incompatible with GPL
  * src/snprintf.c uses the "Frontier Artistic License", AFAICS never approved
    for Fedora (http://fedoraproject.org/wiki/Licensing)
  (In both cases the functionality is probably unnecessary and the files could
  be removed from the source tarball)
  * LICENSE-snprintf.txt is not provided in %doc

* rpmlint:
  > aide.x86_64: W: log-files-without-logrotate /var/log/aide
  Can the log file grow without bounds?

* Uses %makeinstall, is it necessary? Makefile.in seems to support DESTDIR.

* Uses %define, should use %global instead

* Low-severity:
  * The "nostatic" macro is defined, but not used
  *
https://fedoraproject.org/wiki/Packaging/Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.