[Bug 536944] Review Request: jai-imageio-core - Core Java Advanced Imaging Image I/O Tools API

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=536944

--- Comment #3 from Mary Ellen Foster <mefoster at gmail.com> 2010-02-03 11:14:40 EST ---
Ack! Sorry I took so long to get back to this ... only one thing really to
change (the issue with generate-tarball.sh) and it otherwise looks good

Review:
OK: rpmlint must be run on every package.
Output:
jai-imageio-core.src: W: strange-permission generate-tarball.sh 0775

===> False positive from the source package

jai-imageio-core.src: W: spelling-error %description -l en_US codecLib ->
codeine, decliner, code's
jai-imageio-core.src:140: W: libdir-macro-in-noarch-package (main package)
%{_libdir}/gcj/%{name}
jai-imageio-core.src: W: invalid-url Source0:
jai-imageio-core-cvs20100111-CLEANED.tar.xz
jai-imageio-core.x86_64: W: spelling-error %description -l en_US codecLib ->
codeine, decliner, code's
jai-imageio-core-javadoc.noarch: W: spelling-error Summary(en_US) Javadocs ->
Java docs, Java-docs, Javanese
===> False positives

jai-imageio-core-debuginfo.x86_64: E: script-without-shebang
/usr/src/debug/jai-imageio-core-cvs20100111-CLEANED/src/share/classes/com/sun/media/imageioimpl/plugins/gif/GIFImageMetadataFormat.java
jai-imageio-core-debuginfo.x86_64: E: script-without-shebang
/usr/src/debug/jai-imageio-core-cvs20100111-CLEANED/src/share/classes/com/sun/media/imageioimpl/plugins/gif/GIFImageMetadata.java
jai-imageio-core-debuginfo.x86_64: E: script-without-shebang
/usr/src/debug/jai-imageio-core-cvs20100111-CLEANED/src/share/classes/com/sun/media/imageioimpl/plugins/gif/GIFStreamMetadataFormatResources.java
jai-imageio-core-debuginfo.x86_64: E: script-without-shebang
/usr/src/debug/jai-imageio-core-cvs20100111-CLEANED/src/share/classes/com/sun/media/imageioimpl/plugins/gif/GIFStreamMetadata.java
jai-imageio-core-debuginfo.x86_64: E: script-without-shebang
/usr/src/debug/jai-imageio-core-cvs20100111-CLEANED/src/share/classes/com/sun/media/imageioimpl/plugins/gif/GIFStreamMetadataFormat.java
jai-imageio-core-debuginfo.x86_64: E: script-without-shebang
/usr/src/debug/jai-imageio-core-cvs20100111-CLEANED/src/share/classes/com/sun/media/imageioimpl/plugins/gif/GIFImageMetadataFormatResources.java
jai-imageio-core-debuginfo.x86_64: E: script-without-shebang
/usr/src/debug/jai-imageio-core-cvs20100111-CLEANED/src/share/classes/com/sun/media/imageioimpl/common/PaletteBuilder.java
===> All false positives from the debuginfo package

OK: The package must be named according to the Package Naming Guidelines .
OK: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
OK: The package must meet the Packaging Guidelines .
OK: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines .
OK: The License field in the package spec file must match the actual license.
OK: The spec file must be written in American English.
OK: The spec file for the package MUST be legible.
FIX: The sources used to build the package must match the upstream source, as
provided in the spec URL.
===> generate-tarball.sh uses the current date to check out the tarball and
checks out the HEAD revision. I'd suggest changing it to take the date as a
second parameter and to use that date as the checkout command. I'll attach the
patch that worked for me; feel free to do this or something else.

Note that even with this change, I ended up with a file with a different md5sum
than the one that included in your SRPM, and I'm not sure why -- maybe because
I'm on a 64-bit computer?

OK: The package MUST successfully compile and build into binary rpms on at
least one primary architecture.
OK: All build dependencies must be listed in BuildRequires
OK: Packages must NOT bundle copies of system libraries.
OK: A package must own all directories that it creates.
OK: A Fedora package must not list a file more than once in the spec file's
%files listings.
OK: Permissions on files must be set properly.
OK: Each package must have a %clean section, which contains rm -rf %{buildroot}
(or $RPM_BUILD_ROOT).
OK: Each package must consistently use macros.
OK: The package must contain code, or permissable content.
OK: Packages must not own files or directories already owned by other packages.
OK: At the beginning of %install, each package MUST run rm -rf %{buildroot}
OK: All filenames in rpm packages must be valid UTF-8.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.