[Bug 529548] Review Request: mingw32-libogg - MinGW build of the libogg bitstream library

bugzilla at redhat.com bugzilla at redhat.com
Thu Feb 4 12:55:46 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=529548

Kalev Lember <kalev at smartlink.ee> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kalev at smartlink.ee

--- Comment #18 from Kalev Lember <kalev at smartlink.ee> 2010-02-04 07:55:40 EST ---
I have a few late comments.

The -debuginfo subpackage is empty. This is caused by a missing define:
%define __debug_install_post %{_mingw32_debug_install_post}

You have this:
# Automatically create a debuginfo package
%{_mingw32_debug_package}

Instead of using %{_mingw32_debug_package}, it's better to use
%{?_mingw32_debug_package} (notice the question mark) to work around a problem
with macros showing up unexpanded in description in Koji. See [1] for an
explanation of this issue.
Can you do a new Koji scratch build to be sure that debuginfo issues are fixed?

Now that the binaries are stripped automatically, you can kill those two lines:
# Uncomment and unescape to strip the debug symbols from the resulting
artifacts
#%%{_mingw32_strip} --strip-unneeded
%%{buildroot}%%{_mingw32_bindir}/libogg-0.dll

Requires: pkgconfig is unneccessary in Fedora (but needed if you plan to build
for EPEL). RPM in current Fedora releases is capable of extracting pkgconfig
deps automatically. See [2] for updated guidlines. You don't neccessarily have
to change anything here, just pointing it out.

[1] http://lists.fedoraproject.org/pipermail/devel/2010-February/130357.html
[2] https://fedoraproject.org/wiki/Packaging/Guidelines#Pkgconfig_Files

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list