[Bug 495693] Review Request: perl-Syntax-Highlight-Perl6 - Perl 6 Syntax Highlighter

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=495693

--- Comment #10 from Iain Arnell <iarnell at gmail.com> 2010-02-04 11:12:12 EST ---
+ source files match upstream.  
  10dec91d5a7bb1f1df32e9a87d31de94  Syntax-Highlight-Perl6-0.78.tar.gz

+ package meets naming and versioning guidelines.
+ specfile is properly named, is cleanly written and uses macros consistently.
+ summary is OK.
+ description is OK.
+ dist tag is present.
+ build root is OK.
+ license field matches the actual license.
  (GPL+ or Artistic) and Artistic 2.0 and (MIT or GPLv2)

+ license is open source-compatible.
+ license text not included upstream.
+ latest version is being packaged.
+ BuildRequires are proper.
+ compiler flags are appropriate.
+ %clean is present.
+ package builds in mock
  http://koji.fedoraproject.org/koji/taskinfo?taskID=1963313
+ package installs properly.
- rpmlint has no complaints:
  perl-Syntax-Highlight-Perl6.noarch: I: checking
  perl-Syntax-Highlight-Perl6.noarch: E: wrong-script-interpreter
/usr/share/perl5/Cursor.pmc perl
  perl-Syntax-Highlight-Perl6.noarch: E: non-executable-script
/usr/share/perl5/Cursor.pmc 0644 perl
  perl-Syntax-Highlight-Perl6.src: I: checking
  perl-Syntax-Highlight-Perl6.src:18: W: unversioned-explicit-provides
perl(STD)
  perl-Syntax-Highlight-Perl6.src:18: W: unversioned-explicit-provides
perl(mangle.pl)

+ final provides and requires are sane:
  perl(Cursor)  
  perl(DEBUG)  
  perl(LazyMap)  
  perl(NAME)  
  perl(STD)  
  perl(Stash)  
  perl(Syntax::Highlight::Perl6) = 0.78
  perl(Syntax::Highlight::Perl6::Actions)  
  perl(mangle.pl)  
  perl-Syntax-Highlight-Perl6 = 0.78-1.fc13
=
  perl >= 1:5.010
  perl(:MODULE_COMPAT_5.10.1)  
  perl(Carp)  
  perl(Cwd)  
  perl(DEBUG)  
  perl(Encode)  
  perl(Exporter)  
  perl(File::Basename)  
  perl(File::Copy)  
  perl(File::Path)  
  perl(File::Spec)  
  perl(LazyMap)  
  perl(Moose)  
  perl(Moose) >= 0.89
  perl(NAME)  
  perl(STD)  
  perl(Stash)  
  perl(Storable)  
  perl(Term::ANSIColor)  
  perl(YAML::XS)  
  perl(YAML::XS) >= 0.32
  perl(feature)  
  perl(mangle.pl)  
  perl(open)  
  perl(overload)  
  perl(strict)  
  perl(utf8)  
  perl(warnings)  

+ %check is present and all tests pass.
  t/00-syntax.t .... ok
  t/01-std.t ....... ok
  t/02-hilitep6.t .. ok
  All tests successful.
  Files=3, Tests=69, 17 wallclock secs ( 0.04 usr  0.00 sys +  5.21 cusr  0.42
csys =  5.67 CPU)
  Result: PASS

+ no shared libraries are added to the regular linker search paths.
+ owns the directories it creates.
+ doesn't own any directories it shouldn't.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no generically named files
+ code, not content.
+ documentation is small, so no -doc subpackage is necessary.
+ %docs are not necessary for the proper functioning of the package.


It's close.  Only real problem is with rpmlint output.  I guess you can just
strip the first line from Cursor.pmc to fix the reported errors.

  perl-Syntax-Highlight-Perl6.noarch: E: wrong-script-interpreter
/usr/share/perl5/Cursor.pmc perl
  perl-Syntax-Highlight-Perl6.noarch: E: non-executable-script
/usr/share/perl5/Cursor.pmc 0644 perl


But the warnings for unversioned provides should be okay (after all, the
automatically detected provides are mostly unversioned too).

  perl-Syntax-Highlight-Perl6.src:18: W: unversioned-explicit-provides
perl(STD)
  perl-Syntax-Highlight-Perl6.src:18: W: unversioned-explicit-provides
perl(mangle.pl)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.