[Bug 561271] Review Request: paktype-tehreer-fonts - Fonts for Arabic from PakType

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=561271

--- Comment #3 from Parag AN(पराग) <panemade at gmail.com> 2010-02-04 23:56:09 EST ---
Review:
+ package builds in mock (rawhide i686).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1962490
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url (sha1sum)
f2b9a49f79ac749b233b8325a9e743a12ea1a0dc  PakType_Tehreer.ttf
6dbd5c5e987a72f0512bb991ac80c3c61b49f22c  License.txt
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Does owns the directories it creates.
+ fontconfig scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Not a GUI application

Suggestions:
1) fix rpmint using sed
2) use always wherever possible wget to download sources to keep timestamp same
as upstream.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.