[Bug 560242] Review Request: fontaine - Font file meta information utility

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=560242

Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #7 from Parag AN(पराग) <panemade at gmail.com> 2010-02-05 01:16:36 EST ---
Review:
+ package builds in mock (rawhide i686).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1959894
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url 
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Not a GUI application

NOTE:-
  I tried to see if translations are working or not but have not got any
success when I ran
============================================================
LANG=zh_CN.UTF-8 /usr/bin/fontaine -h

Fontaine
Version 1.0 alpha
Copyright ⓒ 2009 by Edward H. Trager. All Rights Reserved. Released under GPL
v. 2 or later.
http://www.unifont.org
==============================================================
I think above license text is translated but not worked for me.

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.