[Bug 560289] Review Request: perl-CGI-Application-Plugin-MessageStack - Message stack for your CGI::Application

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=560289

--- Comment #2 from Chris Weyl <cweyl at alumni.drew.edu> 2010-02-06 13:37:04 EST ---
Another nice, clean perl package.  Looks good!

This is not a blocker, but please consider adding "%{?perl_default_filter}" to
your spec, before the %description block; even if the addition is merely
pro-forma for this package.

koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=1966684

Spec looks sane, clean and consistent; license is correct (GPL+ or Artistic);
make test passes cleanly.

Source tarballs match upstream (sha1sum):
72f9fe6ef0b26583e2246ec8b276fbdc11264f0e
CGI-Application-Plugin-MessageStack-0.34.tar.gz
72f9fe6ef0b26583e2246ec8b276fbdc11264f0e
CGI-Application-Plugin-MessageStack-0.34.tar.gz.srpm

Final provides / requires are sane:

0 packages and 1 specfiles checked; 0 errors, 0 warnings.
=====> perl-CGI-Application-Plugin-MessageStack-0.34-1.fc12.noarch.rpm <=====
====> rpmlint
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
====> provides for
perl-CGI-Application-Plugin-MessageStack-0.34-1.fc12.noarch.rpm
perl(CGI::Application::Plugin::MessageStack) = 0.34
perl-CGI-Application-Plugin-MessageStack = 0.34-1.fc12
====> requires for
perl-CGI-Application-Plugin-MessageStack-0.34-1.fc12.noarch.rpm
perl >= 0:5.006
perl(CGI::Application) >= 4.01
perl(:MODULE_COMPAT_5.10.0)  
perl(strict)  
perl(vars)  
perl(warnings)  

=====> perl-CGI-Application-Plugin-MessageStack-0.34-1.fc12.src.rpm <=====
====> rpmlint
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
====> provides for perl-CGI-Application-Plugin-MessageStack-0.34-1.fc12.src.rpm
====> requires for perl-CGI-Application-Plugin-MessageStack-0.34-1.fc12.src.rpm
perl(CGI::Application)  
perl(CGI::Application::Plugin::Session)  
perl(CGI::Application::Plugin::TT)  
perl(Module::Build)  
perl(Test::More)  
perl(Test::Pod)  

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.