[Bug 561470] Review Request: beakerlib - shell-level integration testing library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=561470

--- Comment #7 from Petr Šplíchal <psplicha at redhat.com> 2010-02-08 04:44:55 EST ---
> Can the .spec summary be made more specific?  Presently, it says
> "An operating system integration testing harness".  Is that the
> correct summary for beakerlib?

What about using the summary from the wiki? Should be quite
up-to-date and more specific:

Summary:

    A shell-level integration testing library

Description:

    BeakerLib is a shell-level integration testing library,
    providing convenience functions which simplify writing,
    running and analysis of integration and blackbox tests.

    The essential features are:

    * Journal - uniform logging mechanism (saved in XML format)
    * Phases - clear separation of setup / test / cleanup
    * Asserts - common checks (exit codes, check file existence & content)
    * Common operations - managing services, backup & restore 

> * MUST: The License field in the package spec file must match the actual
> license.
> 
> FAIL - 
>  * I can't tell by looking at the code what the license is.  You may wish to
> include a LICENSE file.

I'll add the LICENSE file as part of the documentation update patch.

>  * The Makefile lists '# License: GPL v2 or later', but the package is listed
> as GPLv2.  if this is the case, you may wish to change the .spec file License:
> GPLv2+
>  * src/staf-rhts/BEAKERLIB.pm shows "Eclipse Public License (EPL) V1.0" which
> is not compatible with the GPLv2 (see
> http://fedoraproject.org/wiki/Licensing#SoftwareLicenses).

The staf-rhts directory should be removed altogether I guess. This
is Beaker-Staff integration stuff which has not been used AFAIK.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.