[Bug 560169] Review Request: bytelist - A java library for lists of bytes

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=560169

--- Comment #2 from Mohammed Morsi <mmorsi at redhat.com> 2010-02-08 14:11:07 EST ---
Looks good for most part, builds find in mock and passes most review
guidelines. 

A couple of specifics though:

The following line doesn't work as intended:
find -name '*.jar' -o -name '*.class' -exec rm -f '{}' \;

You can replace it w/ this:
find \( -name '*.jar' -o -name '*.class' \) -exec rm -rf {} \;


Also I was able to compile the bytelist rpm w/ the java-gcj features. See the
guidelines / my bytelist spec for how to do so:

http://fedoraproject.org/wiki/Packaging/GCJGuidelines
http://mo.morsi.org/files/jruby/bytelist.spec


As far as the changelog you have a typo, "Jun 2010" should be "Jan 2010". 

Also why did you remove the previous entries from the changelog
http://cvs.fedoraproject.org/viewvc/rpms/bytelist/F-11/bytelist.spec?view=markup

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.