[Bug 560172] Review Request: jvyamlb - YAML processor for JRuby

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=560172

--- Comment #2 from Victor G. Vasilyev <victor.vasilyev at sun.com> 2010-02-08 21:13:43 EST ---
(In reply to comment #1)
> 
> The following line doesn't work as intended:
> find -name '*.jar' -o -name '*.class' -exec rm -f '{}' \;
> 
> You can replace it w/ this:
> find \( -name '*.jar' -o -name '*.class' \) -exec rm -rf {} \;
> 
fixed according to the Specfile Template for ant
https://fedoraproject.org/wiki/Packaging:Java#ant_2

> 
> As far as the changelog you have a typo, "Jun 2010" should be "Jan 2010". 
>
fixed

> Also why did you remove the previous entries from the changelog
> http://cvs.fedoraproject.org/viewvc/rpms/jvyamlb/F-11/jvyamlb.spec?view=markup
>
No, changelog in the release 0.2.5-3 contains full history.

> Also I didn't try, but if it works w/ gcj (java-devel >= 1.5) adding gcj
> support to the spec is relatively easy:
> http://fedoraproject.org/wiki/Packaging/GCJGuidelines
Releases of the package was never containing gcj bits.
We shouldn't add stuff of the deprecated technology into this package.
Clarification is here:
https://bugzilla.redhat.com/show_bug.cgi?id=560170#c5

The release 4 is prepared for review:
Spec URL: http://victorv.fedorapeople.org/files/jvyamlb.spec
SRPM URL: http://victorv.fedorapeople.org/files/jvyamlb-0.2.5-4.fc13.noarch.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.