[Bug 562330] Review Request: libnih - Lightweight application development library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=562330

--- Comment #5 from Eric Smith <eric at brouhaha.com> 2010-02-08 22:20:37 EST ---
I've confirmed that it now builds with mock for Fedora 12 x86_64, the resulting
RPMs install, and nih-dbus-tool works at least as far as getting a usage
message.  (I don't know how to test beyond that.)  I agree that everything but
the rpmlint hardcoded-library-path error and the licensing issue have been
fixed.

rpmlint reports:
libnih.spec:63: E: hardcoded-library-path in %{_prefix}/lib/pkgconfig/*
libnih.x86_64: W: unused-direct-shlib-dependency /lib64/libnih-dbus.so.1.0.0
/lib64/libpthread.so.0
3 packages and 1 specfiles checked; 1 errors, 1 warnings.

I'm not sure why it's getting the warning.

The package looks good other than the hardcoded-library-path and the licensing
issue.  Have you submitted a ticked upstream to get the licensing fixed?  I
don't think I can approve the package with either issue (I've already been
chastised once for approving a package where I overlooked some source files
without copyright/license information), but if another reviewer is willing to
do it, they should feel free to reassign this review request to themself.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.