[Bug 562330] Review Request: libnih - Lightweight application development library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=562330

--- Comment #8 from Petr Lautrbach <plautrba at redhat.com> 2010-02-09 07:11:38 EST ---
> MUST: The package must be licensed with a Fedora approved license and meet the 
> Licensing Guidelines. NEEDSWORK
> None of the source files in nih-dbus-tool/tests/expected have copyright and
> license information, and I don't see a blanket statement that covers them.

License is included in source tar ball in file COPYING so there is no need to
specify it in every single file again.

>> rpmlint reports:
>> libnih.spec:63: E: hardcoded-library-path in %{_prefix}/lib/pkgconfig/*

> This one is OK as long as the pkgconfig file is arch independent.

No, it's not:
$ diff libnih.pc libnih-x86_64.pc
3c3
< libdir=/lib
---
> libdir=/lib64

But it's ok, it just hits this part of spec file:

test "lib" = "%{_lib}" || \
        mv $RPM_BUILD_ROOT%{_prefix}/lib/pkgconfig/* \
        $RPM_BUILD_ROOT%{_libdir}/pkgconfig



I'm missing section %check. Why it is not included as it is in upstart?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.