[Bug 561439] Review Request: aduna-commons-pom - Aduna Commons parent pom

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=561439

--- Comment #1 from Adam Goode <adam at spicenitz.org> 2010-02-09 23:37:58 EST ---
rpmlint:

aduna-commons-pom.noarch: W: no-documentation
aduna-commons-pom.noarch: W: non-conffile-in-etc
/etc/maven/fragments/aduna-commons-pom
2 packages and 0 specfiles checked; 0 errors, 2 warnings.

Seems ok.


All MUSTs pass.

A few comments:

 * Consider using cp -a or something like that to preserve the timestamps in
%prep.
 * Consider including the upstream license as a source and put into %doc.

All other SHOULDs look good.


Also, the SRPM wasn't in the right place, I had to dig around in the webspace
for it.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.