[Bug 563510] Review Request: php-xcache - yet another php cacher

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=563510

Matthias Runge <mrunge at fedoraproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mrunge at fedoraproject.org

--- Comment #5 from Matthias Runge <mrunge at fedoraproject.org> 2010-02-10 15:09:06 EST ---
As I'm not approved, I could only provide an unofficial review:

rpmlint ../RPMS/i686/php-xcache-1.3.0-1.fc12.i686.rpm
../RPMS/i686/php-xcache-debuginfo-1.3.0-1.fc12.i686.rpm php-xcache.spec 
2 packages and 1 specfiles checked; 0 errors, 0 warnings. (ok)

* name meets naming convention (ok)

* can not verify license (BSD given in SPEC, couldn't find this in code, esp.
COPYING does not mention BSD)

* Mixing $RPM_BUILD_ROOT and %{buildroot} should not be done (cf. Packaging
guidelines in Fedora wiki)

* %global preferred over %define (used both)

* some code in SPEC is commented out, decreases readability. Why don't you
remove those lines? Why is code for RHEL 4 and RHEL 5 included?

* Package compiles succesful into binary RPMS

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.