[Bug 559699] Review Request: RE-REVIEW of qpid-cpp (rename of qpidc)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=559699

--- Comment #6 from Nuno Santos <nsantos at redhat.com> 2010-02-11 12:05:34 EST ---
Fabio,

please find updated SRPM and specfile at the same URLs:

SRPM: http://people.redhat.com/~nsantos/qpid-cpp-0.5.829175-4.fc13.src.rpm
spec: http://people.redhat.com/~nsantos/qpid-cpp.spec


I put the patches back in, it's generating the correct version of .so now.

Regarding the version, this is 0.5.829175-4, which is higher than what was in
rawhide before (qpidc-0.5.819819-1.fc13), and the same codebase but a revision
higher than what's in F12 (qpidc-0.5.829175-3.fc12).

I fixed most of the warnings from rpmlint (except for "no-documentation", etc),
but these errors are still present (explanations for each are inline):
* qpid-cpp-server.i686: E: non-readable /var/lib/qpidd/qpidd.sasldb 0600
  - this is supposed to non-readble
* qpid-cpp-server-store.i686: E: explicit-lib-dependency libaio
  - there is no explicit lib dependency, there is a requires for a package
    named libaio: "Requires: libaio" (line 281)
* qpid-cpp-server-store.i686: E: non-standard-dir-perm /var/rhm 0775
  - supposed to have those permissions
* ruby-qmf.i686: E: binary-or-shlib-defines-rpath
/usr/lib/ruby/site_ruby/1.8/i386-linux/qmfengine.so
['/builddir/build/BUILD/qpidc-0.5.829175/cpp/src/.libs']
  - not sure why it's complaining, I'm using the standard ruby_sitelib and
ruby_sitearch macros, not hardcoding any path

Nuno

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.