[Bug 561470] Review Request: beakerlib - shell-level integration testing library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=561470

--- Comment #10 from Petr Muller <pmuller at redhat.com> 2010-02-12 11:12:43 EST ---
Spec URL: http://www.afri.cz/files/beakerlib.spec
SRPM URL: http://www.afri.cz/files/beakerlib-1.0-2.src.rpm

(In reply to comment #8)
> Bzzz! Noarch plus %_libdir won't fly, since the value of %_libdir would change
> with the build host.

No libdir now. All scripts meant for sourcing are now in /usr/share/beakerlib/,
all files meant for executing are in /usr/bin and prefixed 'beakerlib-'.

> > Source0:    %{name}-%{version}.tar.gz
> This is no valid URL where to download the tarball. If the tarball cannot be
> downloaded anywhere, please add a comment on how to construct it from a scm
> repository.
I placed the tarball at the website and provided a link to it. It's a link to
Trac attachment.

> > https://fedorahosted.org/git/beakerlib.git> 
> That redirects to:
>   https://fedorahosted.org/web/410
>   No such project.
>   The requested project does not exist on Fedora Hosted.
Sorry, the right URL is http://git.fedorahosted.org/git/beakerlib.git. Anyways,
Source now point directly to the tarball attachment, not osurce repo.

> > Obsoletes: rhtslib beaker-lib
> > Provides: rhtslib beaker-lib
> Nothing provides these so far. Even if it may be "old names": IMO, it's being
> frowned upon to provide alternative virtual package names just for fun. My
> suggestion: keep the Obsoletes with proper max. version, but don't add the
> Provides. It's silly to run with multiple alternative/competing packages names,
> whether virtual or not.

We've decided to remove these entirely, as the names are not present in Fedora.

> > %makeinstall DESTDIR=$RPM_BUILD_ROOT
> 
> Please prefer "make DESTDIR=$RPM_BUILD_ROOT install" over %makeinstall unless
> the normal "make install ..." doesn't work.  The macro redefines many values,
> which bears a risk.

Fixed

> > /usr/lib/beakerlib/python/journal-compare.py*
> Which packages owns /usr/lib/beakerlib/python/?
> > /usr/lib/beakerlib/perl/deja-summarize
> Which packages owns /usr/lib/beakerlib/perl/?

Not applicable now. Package now needs /usr/share/beakerlib and
/usr/share/doc/beakerlib, both are owned by it.

> > %{_mandir}/man1/beakerlib*1.gz
> 
> Since man pages typically are compressed transparently by rpmbuild, prefer a
> wildcard over a file extension such as .gz:
> %{_mandir}/man1/beakerlib*1*    

Fixed

rpmlint is now silent on the package

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.