[Bug 564537] Review Request: grc - simple python logfile colouriser

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=564537

--- Comment #2 from Carl van Tonder <carl at supervacuo.com> 2010-02-13 08:45:30 EST ---
Spec URL: http://supervacuo.com/fedora/grc.spec
SRPM URL: http://supervacuo.com/fedora/grc-1.3-0.2.fc12.src.rpm

> Why so uncommon release tag, what't wrong with 1%{?dist}?
It started life as a "personal use" package; fixed

> Add a comment about why %build in empty.
Done; it's because there is no "compilation" step — grc and grcat are python
scripts

> %install will cd into source dir, you should use:
> ./install.sh  $RPM_BUILD_ROOT
> I don't understand why you need the build patch, (which is a install patch:-)
For some reason, specifying relative paths seemed not to work yesterday, but
now it does indeed work. Patch now removed.

Thanks for taking a look!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.