[Bug 560457] Review Request: pyutil - A collection of mature utilities for Python programmers

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=560457

Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |mtasaka at ioa.s.u-tokyo.ac.jp
               Flag|                            |fedora-review?

--- Comment #10 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> 2010-02-13 11:28:12 EST ---
Well,

* BuildRequires/Requires
  - Please check if "python-zbase32" "python-twisted-core"
    "python-argparse" should be listed only for BuildRequires.
    ! For example
      ./pyutil/iputil.py contains:
-------------------------------------------------------------
     9  # from Twisted
    10  from twisted.internet import defer, reactor
    11  from twisted.python import failure
    12  from twisted.internet.protocol import DatagramProtocol
    13  from twisted.internet.utils import getProcessOutput
    14  from twisted.python.procutils import which
    15  from twisted.python import log
-------------------------------------------------------------
      It seems that pyutil should also have "Requires:
      python-twisted-core".

* rpmlint
-------------------------------------------------------------
pyutil.noarch: E: non-executable-script
/usr/lib/python2.6/site-packages/pyutil/test/test_iputil.py 0644L /usr/bin/env
pyutil.noarch: E: non-executable-script
/usr/lib/python2.6/site-packages/pyutil/test/test_picklesaver.py 0644L
/usr/bin/env
pyutil.noarch: E: non-executable-script
/usr/lib/python2.6/site-packages/pyutil/scripts/randfile.py 0644L /usr/bin/env
pyutil.noarch: E: non-executable-script
/usr/lib/python2.6/site-packages/pyutil/scripts/randcookie.py 0644L
/usr/bin/env
pyutil.noarch: E: non-executable-script
/usr/lib/python2.6/site-packages/pyutil/test/test_mathutil.py 0644L
/usr/bin/env
pyutil.noarch: E: non-executable-script
/usr/lib/python2.6/site-packages/pyutil/lineutil.py 0644L /usr/bin/env
pyutil.noarch: E: non-executable-script
/usr/lib/python2.6/site-packages/pyutil/test/test_template 0644L /usr/bin/env
pyutil.noarch: E: non-executable-script
/usr/lib/python2.6/site-packages/pyutil/test/test_dictutil.py 0644L
/usr/bin/env
pyutil.noarch: E: non-executable-script
/usr/lib/python2.6/site-packages/pyutil/benchmarks/bench_xor.py 0644L
/usr/bin/env
pyutil.noarch: E: non-executable-script
/usr/lib/python2.6/site-packages/pyutil/test/test_time_format.py 0644L
/usr/bin/env
pyutil.noarch: E: non-executable-script
/usr/lib/python2.6/site-packages/pyutil/test/test_strutil.py 0644L /usr/bin/env
pyutil.noarch: E: non-executable-script
/usr/lib/python2.6/site-packages/pyutil/scripts/tailx.py 0644L /usr/bin/env
pyutil.noarch: E: non-executable-script
/usr/lib/python2.6/site-packages/pyutil/test/test_odict.py 0644L /usr/bin/env
pyutil.noarch: E: non-executable-script
/usr/lib/python2.6/site-packages/pyutil/test/test_zlibutil.py 0644L
/usr/bin/env
pyutil.noarch: E: non-executable-script
/usr/lib/python2.6/site-packages/pyutil/scripts/lines.py 0644L /usr/bin/env
pyutil.noarch: E: non-executable-script
/usr/lib/python2.6/site-packages/pyutil/scripts/memdump2dot.py 0644L
/usr/bin/env
pyutil.noarch: E: non-executable-script
/usr/lib/python2.6/site-packages/pyutil/scripts/unsort.py 0644L /usr/bin/env
pyutil.noarch: E: non-executable-script
/usr/lib/python2.6/site-packages/pyutil/test/test_assertutil.py 0644L
/usr/bin/env
pyutil.noarch: E: non-executable-script
/usr/lib/python2.6/site-packages/pyutil/test/test_xor.py 0644L /usr/bin/env
pyutil.noarch: E: non-executable-script
/usr/lib/python2.6/site-packages/pyutil/test/test_cache.py 0644L /usr/bin/env
pyutil.noarch: E: non-executable-script
/usr/lib/python2.6/site-packages/pyutil/test/test_jsonutil.py 0644L
/usr/bin/env
-------------------------------------------------------------
  - These scripts should not have shebang.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.