[Bug 555653] Review Request: ghc-haskeline - Haskell command-line interface for user input

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=555653

Jens Petersen <petersen at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #4 from Jens Petersen <petersen at redhat.com> 2010-02-15 02:23:07 EST ---
Thanks for reviewing! :)

> ghc-haskeline.src: W: strange-permission haskeline-0.6.2.1.tar.gz 0600

Ugh again (silly chromium) - yup will fix

> ghc-haskeline.spec: W: no-cleaning-of-buildroot %install
> ghc-haskeline.spec: W: no-buildroot-tag

I believe these are now optional though rpmlint still complains.

> - [ BAD ] MUST: At the beginning of %install, each package MUST run
> rm -rf %{buildroot} (or $RPM_BUILD_ROOT). See Prepping BuildRoot For
> %install for details.

See the note at
https://fedoraproject.org/wiki/Packaging/Guidelines#PreppingBuildRootForInstall

So should be ok. :)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.