[Bug 557021] Review Request: rubygem-merb-gen - Application and plugin generator scripts for Merb

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=557021

--- Comment #2 from Matthew Kent <mkent at magoazul.com> 2010-02-16 00:48:06 EST ---
Thanks for the review!

(In reply to comment #1)
> Looks okay, also your test passes.
> 
> One question:
> - About "rake spec"
>   Currently rake_helpers.rb is missing. Perhaps this file is the below:
>   http://github.com/wycats/merb/blob/master/rake_helpers.rb
> 

Yeah I think they forgot to update the gemspec before the latest release. Looks
fixed now.

>   Anyway without this file, chaging Rakefile as below seems to
>   make "rake spec" pass:
> --------------------------------------------------------------------
> --- Rakefile.orig       1970-01-01 09:00:00.000000000 +0900
> +++ Rakefile    2010-02-13 01:50:28.000000000 +0900
> @@ -1,4 +1,10 @@
> -require File.expand_path(File.join(File.dirname(__FILE__), "..",
> "rake_helpers"))
> +#require File.expand_path(File.join(File.dirname(__FILE__), "..",
> "rake_helpers"))
> +begin ; require "rubygem" ; rescue LoadError ; end
> +require "merb-core"
> +require "rake"
> +require "rake/gempackagetask"
> +require "spec"
> +require "spec/rake/spectask"
> 
>  

Looks good to me and tests okay. Thanks!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.