[Bug 563510] Review Request: php-xcache - yet another php cacher

bugzilla at redhat.com bugzilla at redhat.com
Tue Feb 16 10:34:05 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=563510

--- Comment #19 from Timon <timosha at gmail.com> 2010-02-16 05:34:02 EST ---
(In reply to comment #15)
> Quick notes
> 
> - don't understand why you try to register this as a pecl extension (%post /
> %postun). 
> This is not a pecl extension, and you don't have the package.xml file required
> for this.
> - so, could also be removed
> %global pecl_name xcache
> Requires(post): %{__pecl}
> Requires(postun): %{__pecl}
> Provides:      php-pecl(%{pecl_name}) = %{version}
I used php-pecl-apc as template.
fixed

> - xcache.ini 
> zend_extension = /EXT_DIR/xcache.so
> no need to give full path.
http://ru2.php.net/manual/en/ini.core.php#ini.zend-extension
Absolute path required.

> - %defattr(-, root, root, 0755)
> (-,root,root,-) must be enough. php script should be 644 
> This will remove a lot of rpmlint message
> php-xcache.x86_64: E: script-without-shebang /usr/share/php-xcache/admin/...
fixed

> - admin / coverager
> You need to create a alias (httpd/conf.d) to give access to admin URL.
> probably also need a writable dir for xcache.coveragedump_directory
> If you don't want to make this available, don't install it, just add it in %doc
Fixed. I move them to %doc.

> - INSTALL
> don't need this file in RPM
fixed

> - Buildroot
> is acceptable, but read
> http://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot
fixed. 
BuildRoot:     %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)


(In reply to comment #16)
> Can you post a updated spec file + src.rpm ?
php-xcache.spec: https://bugzilla.redhat.com/attachment.cgi?id=394498 
php-xcache-1.3.0-4.fc12.src.rpm:
https://bugzilla.redhat.com/attachment.cgi?id=394499

> also can you include a koji scratch build ?    
[timon at timon rpmbuild]$ koji build --scratch dist-f12
SRPMS/php-xcache-1.3.0-4.fc12.src.rpm Uploading srpm:
SRPMS/php-xcache-1.3.0-4.fc12.src.rpm
[====================================] 100% 00:00:05 107.71 KiB  21.09 KiB/sec
Created task: 1990279
Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=1990279
None
Watching tasks (this may be safely interrupted)...
1990279 build (dist-f12, php-xcache-1.3.0-4.fc12.src.rpm): open
(x86-06.phx2.fedoraproject.org)
  1990280 buildArch (php-xcache-1.3.0-4.fc12.src.rpm, ppc): free
  1990281 buildArch (php-xcache-1.3.0-4.fc12.src.rpm, x86_64): free
  1990280 buildArch (php-xcache-1.3.0-4.fc12.src.rpm, ppc): free -> open
(ppc06.phx2.fedoraproject.org)
  1990281 buildArch (php-xcache-1.3.0-4.fc12.src.rpm, x86_64): free -> open
(xb-01.phx2.fedoraproject.org)
  1990283 buildArch (php-xcache-1.3.0-4.fc12.src.rpm, i686): open
(x86-05.phx2.fedoraproject.org)
  1990282 buildArch (php-xcache-1.3.0-4.fc12.src.rpm, ppc64): open
(ppc10.phx2.fedoraproject.org)
  1990283 buildArch (php-xcache-1.3.0-4.fc12.src.rpm, i686): open
(x86-05.phx2.fedoraproject.org) -> closed
  0 free  4 open  1 done  0 failed
  1990281 buildArch (php-xcache-1.3.0-4.fc12.src.rpm, x86_64): open
(xb-01.phx2.fedoraproject.org) -> closed
  0 free  3 open  2 done  0 failed
  1990282 buildArch (php-xcache-1.3.0-4.fc12.src.rpm, ppc64): open
(ppc10.phx2.fedoraproject.org) -> closed
  0 free  2 open  3 done  0 failed
  1990280 buildArch (php-xcache-1.3.0-4.fc12.src.rpm, ppc): open
(ppc06.phx2.fedoraproject.org) -> closed
  0 free  1 open  4 done  0 failed
1990279 build (dist-f12, php-xcache-1.3.0-4.fc12.src.rpm): open
(x86-06.phx2.fedoraproject.org) -> closed
  0 free  0 open  5 done  0 failed

1990279 build (dist-f12, php-xcache-1.3.0-4.fc12.src.rpm) completed
successfully

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list