[Bug 565376] Review Request: qstardict - StarDict clone written in Qt4

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=565376

--- Comment #2 from Cheese Lee <cheeselee at 126.com> 2010-02-16 10:10:13 EST ---
Corrected all following your instructions.
Updated spec and srpm links.
Thank you!

(In reply to comment #1)
> Some notes here:
> Missing %{?_kde4_macros_api:Requires: kde4-macros(api) = %{_kde4_macros_api} }
> before the %description section
> 
> Source:     %{name}-%{version}.tar.bz2 ->
> Source:     http://qstardict.ylsoftware.com/files/%{name}-%{version}.tar.bz2
> 
> Requires:   %name = %version ->
> Requires:   %{name} = %{version}-%{release} 
> 
> qmake-qt4 PLUGINS_DIR=%_libdir/%name/plugins ENABLED_PLUGINS="stardict web" ->
> %_qt4_qmake PLUGINS_DIR=%{_libdir}/%{name}/plugins ENABLED_PLUGINS="stardict
> web"
> 
> %__make -> make(no need to use this macro)
> 
> desktop-file-install --vendor="fedora" --delete-original    \
>     --dir=%{buildroot}%{_datadir}/applications              \
>      %{buildroot}%{_datadir}/applications/%{name}.desktop
> ->
> desktop-file-install --vendor=""    \
>     --dir=%{buildroot}%{_datadir}/applications              \
>      %{buildroot}%{_datadir}/applications/%{name}.desktop
> New packages should not use --vendor="fedora".
> 
> rm -fr %buildroot -> rm -fr %{buildroot}
> rm -fr %buildroot%_datadir/doc -> rm -fr %{buildroot}%{_docdir}

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.